Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleans up old sign up user type experiment #57905

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Cleans up old sign up user type experiment #57905

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5420a23
removing all references to experiment and dcdo flag
hannahbergam Apr 9, 2024
c20fd3f
removing comment
hannahbergam Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
33 changes: 8 additions & 25 deletions apps/src/sites/studio/pages/devise/registrations/_finish_sign_up.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,6 @@ let schoolData = {
// Keep track of whether the current user is in the U.S. or not (for regional partner email sharing)
let isInUnitedStates = schoolData.countryCode === 'US';

// Track whether clearer user type buttons rollout is enabled
const inClearerUserTypeRollout = experiments.isEnabled(
experiments.CLEARER_SIGN_UP_USER_TYPE
);

let userInRegionalPartnerVariant = experiments.isEnabled(
experiments.OPT_IN_EMAIL_REG_PARTNER
);
Expand All @@ -59,23 +54,13 @@ $(document).ready(() => {
function init() {
let hiddenUserType = $('#user_user_type').attr('type') === 'hidden';
if (!hiddenUserType) {
if (inClearerUserTypeRollout) {
// If in variant, toggle large buttons
document.getElementById('select-user-type-original').style.cssText =
'display:none;';
document.getElementById('select-user-type-variant').style.cssText =
'display:flex;';
document.getElementById('signup-select-user-type-label').style.cssText =
'width:135px;';
} else {
// Otherwise (also the default), keep original dropdown
document.getElementById('select-user-type-variant').style.cssText =
'display:none;';
document.getElementById('select-user-type-original').style.cssText =
'display:flex;';
document.getElementById('signup-select-user-type-label').style.cssText =
'width:220px;';
}
// If in variant, toggle large buttons
hannahbergam marked this conversation as resolved.
Show resolved Hide resolved
document.getElementById('select-user-type-original').style.cssText =
'display:none;';
document.getElementById('select-user-type-variant').style.cssText =
'display:flex;';
document.getElementById('signup-select-user-type-label').style.cssText =
'width:135px;';
}
setUserType(user_type);
renderSchoolInfo();
Expand Down Expand Up @@ -171,9 +156,7 @@ $(document).ready(() => {
// Show student fields by default.
switchToStudent();
}
if (inClearerUserTypeRollout) {
styleSelectedUserTypeButton(new_user_type);
}
styleSelectedUserTypeButton(new_user_type);
user_type = new_user_type;
}

Expand Down
1 change: 0 additions & 1 deletion apps/src/util/experiments.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ experiments.I18N_TRACKING = 'frontend-i18n-tracking';
experiments.TIME_SPENT = 'time-spent';
experiments.BYPASS_DIALOG_POPUP = 'bypass-dialog-popup';
experiments.SPECIAL_TOPIC = 'special-topic';
experiments.CLEARER_SIGN_UP_USER_TYPE = 'clearerSignUpUserType';
experiments.OPT_IN_EMAIL_REG_PARTNER = 'optInEmailRegPartner';
// Experiment for showing a backgrounds tab and enabling student upload
// for Sprite Lab animations
Expand Down
1 change: 0 additions & 1 deletion lib/dynamic_config/dcdo.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ def frontend_config
# 'my-new-feature': DCDO.get('my-new-feature', false)
{
'frontend-i18n-tracking': DCDO.get('frontend-i18n-tracking', false),
clearerSignUpUserType: DCDO.get('clearerSignUpUserType', false),
'pl-teacher-application-off-season': DCDO.get('pl_teacher_application', false),
'pl-launch-hero-banner': DCDO.get('pl-launch-hero-banner', false),
'csta-form-extension': DCDO.get('csta-form-extension', false),
Expand Down