Make project template workspace icon tab navigable #57908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher-alice
approved these changes
Apr 9, 2024
|
And thank you for testing in App Lab too! |
sanchitmalhotra126
added a commit
that referenced
this pull request
Apr 10, 2024
This reverts commit 571257c.
sanchitmalhotra126
added a commit
that referenced
this pull request
Apr 10, 2024
sanchitmalhotra126
added a commit
that referenced
this pull request
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Description
Quick follow-up from #57886 to make the ProjectTemplateWorkspaceIcon tab navigable. Thanks to @fisher-alice for writing up this code! Most of it is the same, with some additional work to move inline styles to module styles.
Icon in AI Chat:
Icon in App Lab (non-Lab2):
Compared to current state:
Testing story
Tested with a couple different level types.