Revert "Revert "Make project template workspace icon tab navigable"" #57926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
approved these changes
Apr 10, 2024
fisher-alice
approved these changes
Apr 10, 2024
sanchitmalhotra126
deleted the
revert-57924-revert-57908-sanchit/project-template-icon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #57924
Redo of #57908. The original CSS was somehow causing the height of the button to be larger than its container, forcing scrollbars to appear. Here instead I removed the excess padding and tried to get it to the same position with bottom padding only. It seems to work fine and doesn't produce scrollbars (at least on my machine) across various browsers and screen sizes.
Chrome, small screen (side-by-side with prod)
Chrome, laptop screen (side-by-side with prod)
Chrome, large desktop screen
Firefox
Safari
