Fix-forward for failing Curriculum Catalog UI test with new redirect #57976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
Apr 11, 2024
kelbyhawn
approved these changes
Apr 11, 2024
I know this is so so tiny- but could you rename this to 'fix forward'? I think folks use 'hotfix' as a search term across PRs |
TurnerRiley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updated code.org/professional-development-workshops to redirect to code.org/professional-learning/elementary. This then caused the Curriculum Catalog UI test file to fail since it was searching for a match to a URL that was being redirected away from. This PR updates the expected URL to reflect this now.
Links
Slack discussion: here
PR this builds on: here