Update K5 PL marketing page #57904
Merged
Update K5 PL marketing page #57904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l-development-workshops
these will get added when I merge in another PR
kelbyhawn
commented
Apr 10, 2024
| @@ -23,6 +23,7 @@ theme: responsive_full_width | |||
| %li=hoc_s(:pl_middle_high_top_list_01) | |||
| %li=hoc_s(:pl_middle_high_top_list_02) | |||
| %li=hoc_s(:pl_middle_high_top_list_03) | |||
| %li=hoc_s("pl_page_k5.top_list_04") | |||
There was a problem hiding this comment.
@dmcavoy added this re: this Figma comment
kelbyhawn
commented
Apr 10, 2024
There was a problem hiding this comment.
Here's the updated map styles including responsive:
Screen.Recording.2024-04-10.at.1.13.47.PM.mov
| @@ -77,10 +77,10 @@ section.bg-pattern-dark { | |||
|
|
|||
| // Adds 2rem of space above or below an element | |||
| .add-margin-top { | |||
| margin-top: 2rem; | |||
| margin-top: 2rem !important; | |||
There was a problem hiding this comment.
can you add a comment as to why !important is needed here?
Also, more broadly, sorry for being a stickler here -- as you know, this is an anti-pattern and I'd like to understand why we need to do this. I completely believe that it's needed, just want to know why :)
There was a problem hiding this comment.
Yes definitely! I'll do it in a followup, but the short answer is that this can be used as a utility class that will override existing margin-top on any element.
bethanyaconnor
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the K-5 Professional Learning marketing page https://code.org/professional-learning/elementary
Related PRs:
Jira ticket: ACQ-1412