Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix Violations of and Reenable Style/RescueModifier" #58029

Merged
merged 1 commit into from Apr 16, 2024

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 16, 2024

Reverts #57847

The original PR failed linting during the staging build, because of some stray inline rescues in HAML code which didn't get picked up by Drone or by my local testing:

RAILS_ENV=staging RACK_ENV=staging bundle exec haml-lint dashboard pegasus shared
rake aborted!
'RAILS_ENV=staging RACK_ENV=staging bundle exec haml-lint dashboard pegasus shared' returned 65
warning: parser/current is loading parser/ruby30, which recognizes 3.0.6-compliant syntax, but you are running 3.0.5.
Please see https://github.com/whitequark/parser#compatibility-with-ruby-mri.
dashboard/app/views/layouts/application.html.haml:12 [W] RuboCop: Style/RescueModifier: Avoid using `rescue` in its modifier form.
dashboard/app/views/levels/_admin.html.haml:118 [W] RuboCop: Style/RescueModifier: Avoid using `rescue` in its modifier form.
pegasus/sites.v3/code.org/views/theme_common_head_after.haml:1 [W] RuboCop: Style/RescueModifier: Avoid using `rescue` in its modifier form.
pegasus/sites.v3/hourofcode.com/public/events/2013/index.haml:21 [W] RuboCop: Style/RescueModifier: Avoid using `rescue` in its modifier form.
pegasus/sites.v3/hourofcode.com/public/events/schools/index.haml:21 [W] RuboCop: Style/RescueModifier: Avoid using `rescue` in its modifier form.
pegasus/sites.v3/hourofcode.com/public/events/special/index.haml:21 [W] RuboCop: Style/RescueModifier: Avoid using `rescue` in its modifier form.

1116 files inspected, 6 lints detected
Tasks: TOP => lint => lint:all => lint:haml
(See full trace by running task with --trace)

[CDO]/lib/cdo/rake_utils.rb:81:in `system_stream_output'
[CDO]/lib/cdo/rake_utils.rb:66:in `rake_stream_output'
[CDO]/aws/ci_build:89:in `block in build'
[CDO]/aws/ci_build:65:in `chdir'
[CDO]/aws/ci_build:65:in `build'
[CDO]/aws/ci_build:112:in `block in main'
[CDO]/lib/cdo/rake_utils.rb:329:in `capture'
[CDO]/aws/ci_build:111:in `main'
[CDO]/aws/ci_build:281:in `<main>'
websites failed in 3:45 minutes

@Hamms Hamms marked this pull request as ready for review April 16, 2024 01:33
@Hamms Hamms requested review from a team as code owners April 16, 2024 01:33
@Hamms
Copy link
Contributor Author

Hamms commented Apr 16, 2024

Merging ahead of drone to unblock staging

@Hamms Hamms merged commit 6b13227 into staging Apr 16, 2024
1 of 2 checks passed
@Hamms Hamms deleted the revert-57847-fix-Style/RescueModifier branch April 16, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant