Revert "Revert "Fix Violations of and Reenable Style/RescueModifier""
#58030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
commented
Apr 17, 2024
|
|
||
| %h1= hoc_s(:events_all_old_title).gsub(/\@year/, hoc_year.to_s) | ||
|
|
||
| %ul | ||
| %li{class: "hoc-event-country"} | ||
| %span{style: "font-weight: bold;"}= "United States (#{us_events.count rescue '0'} #{hoc_s(:events)})" | ||
| %span{style: "font-weight: bold;"}= "United States (#{us_events_count} #{hoc_s(:events)})" |
There was a problem hiding this comment.
Note that this is actually a slight refactoring of this very old (and likely entirely unused) page, to better align with how newer pages work. Because us_events is a group of collections, simply calling .count on it will return the number of collections in the group, not the number of events in all the collections.
davidsbailey
approved these changes
Apr 17, 2024
|
Oh, to clarify; Drone will lint HAML files, but only HAML files that have been modified in the PR itself. We could consider linting every file in the codebase for every drone run, but at a cost of slowing down all our drone runs. See #55312 for some previous discussion on the topic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #58029, reapplying #57847
The original PR failed linting when it hit staging, because neither my manual local testing nor automated Drone testing linted haml, and we had a few violations of the new rule hidden in some of our haml templates.
I manually fixed those violations, and verified with
bundle exec haml-lintthat there are no more.