show deprecated course page for script levels with deprecated levels #58163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2024
mikeharv
changed the title
molly-moen
approved these changes
Apr 23, 2024
mikeharv
merged commit 3f5486c
into
mike/deprecate-calc-and-eval-projects
1 check passed
mikeharv
added a commit
that referenced
this pull request
Apr 26, 2024
* show deprecation page for calc and eval projects * deprecate algebra game projects (#58168) * deprecate algebra game projects * Delete big_game_remix.feature * Delete big_game_versions.feature * show deprecated course page for script levels with deprecated levels (#58163) * show deprecated course page for deprecated levels * safely check whether level exists and is deprecated * Deprecate contract match levels (#58191) * show deprecated course page for deprecated levels * deprecate algebra game projects * Delete big_game_remix.feature * safely check whether level exists and is deprecated * deprecate contract match levels * Delete big_game_versions.feature * Update allthethings.script_json * Update and remove tests
mikeharv
added a commit
that referenced
this pull request
Apr 27, 2024
* show deprecation page for calc and eval projects * deprecate algebra game projects (#58168) * deprecate algebra game projects * Delete big_game_remix.feature * Delete big_game_versions.feature * show deprecated course page for script levels with deprecated levels (#58163) * show deprecated course page for deprecated levels * safely check whether level exists and is deprecated * Deprecate contract match levels (#58191) * show deprecated course page for deprecated levels * deprecate algebra game projects * Delete big_game_remix.feature * safely check whether level exists and is deprecated * deprecate contract match levels * Delete big_game_versions.feature * Update allthethings.script_json * Update and remove tests * hide deprecated projects from section projects list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last year, we deprecated several scripts related to CS in Algebra: #53211
However, there are other scripts that use levels of these types. We are gradually working on marking these level types as deprecated:
For projects of these types, we're using the deprecation page and ensuring that the projects no longer show up in the user's personal project table. For levels in scripts, we're currently relying on a script setting. With this change, we can hide unsupported levels in any script. We wouldn't expect deprecated Algebra levels to show up in other scripts, especially those recommend externally. If this does happen we will now show the deprecation warning on those particular script levels. For example, I have found calc/eval levels in scripts like
s/algebrademo. This script isn't recommended anywhere but could potentially have been bookmarked if it was ever shared externally.Before:
After:
This is a more robust solution than just deprecating whole scripts because our content authoring system doesn't guarantee that these unsupported levels won't show up elsewhere.
Note that this doesn't deprecate the whole script or its lessons - just the individual script levels. Eventually we might want to consider automatically showing the deprecation page for any script that includes deprecated levels (since we realistically can't support it). That work is drafted but currently blocked. Algebra levels show up in places like
allthethingswhich we obviously don't want to deprecate, but that is being addressed too: #58190Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: