deprecate algebra game projects #58168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This was referenced Apr 23, 2024
mikeharv
commented
Apr 23, 2024
| @@ -189,4 +189,4 @@ export const NOTIFICATION_ALERT_TYPE = 'notification'; | |||
|
|
|||
| export const START_BLOCKS = 'start_blocks'; | |||
|
|
|||
| export const DEPRECATED_LABS = ['calc', 'eval']; | |||
| export const DEPRECATED_PROJECT_TYPES = ['algebra_game', 'calc', 'eval']; | |||
There was a problem hiding this comment.
I renamed this because 'algebra_game' is technically Play Lab, and so these types aren't really full "labs".
8 tasks
molly-moen
approved these changes
Apr 23, 2024
mikeharv
merged commit 3884e76
into
mike/deprecate-calc-and-eval-projects
1 check passed
mikeharv
added a commit
that referenced
this pull request
Apr 26, 2024
* show deprecation page for calc and eval projects * deprecate algebra game projects (#58168) * deprecate algebra game projects * Delete big_game_remix.feature * Delete big_game_versions.feature * show deprecated course page for script levels with deprecated levels (#58163) * show deprecated course page for deprecated levels * safely check whether level exists and is deprecated * Deprecate contract match levels (#58191) * show deprecated course page for deprecated levels * deprecate algebra game projects * Delete big_game_remix.feature * safely check whether level exists and is deprecated * deprecate contract match levels * Delete big_game_versions.feature * Update allthethings.script_json * Update and remove tests
mikeharv
added a commit
that referenced
this pull request
Apr 27, 2024
* show deprecation page for calc and eval projects * deprecate algebra game projects (#58168) * deprecate algebra game projects * Delete big_game_remix.feature * Delete big_game_versions.feature * show deprecated course page for script levels with deprecated levels (#58163) * show deprecated course page for deprecated levels * safely check whether level exists and is deprecated * Deprecate contract match levels (#58191) * show deprecated course page for deprecated levels * deprecate algebra game projects * Delete big_game_remix.feature * safely check whether level exists and is deprecated * deprecate contract match levels * Delete big_game_versions.feature * Update allthethings.script_json * Update and remove tests * hide deprecated projects from section projects list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to Calc and Eval, which are children of Play Lab (aka Studio), CS in Algebra uses a subtype of Play Lab itself. Play Lab supports the contract editor in the form of "algebra game" projects and levels. We can mark these as deprecated which will prevent users from loading these projects.
Based on:
Once we get the ability to mark specific level types as deprecated (e.g. Calc and Eval), we can extend this as needed to other types.
We should also update our list of deprecated project types for the purpose of filtering student personal projects. This was implemented a few weeks ago #57776 and just requires to add the new project type to a list.
Before:
After:
Warning!!
The AP CSP Create Performance Task is in progress. The most critical dates are from April 3 - April 30, 2024. Please consider any risk introduced by this PR that could affect our students taking AP CSP. Code.org students taking AP CSP primarily use App Lab for their Create Task, however a small percent use Game Lab. Carefully consider whether your change has any risk of alterering, changing, or breaking anything in these two labs. Even small changes, such as a different button color, are considered significant during this time period. Reach out to the Student Learning team or Curriculum team for more details.
Links
Jira: https://codedotorg.atlassian.net/browse/CT-515
Testing story
I manually confirmed that there are no regressions to other Play Lab projects.
As algebra game projects are no longer supported, the related tests will break if they are not removed.
PR Checklist: