-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI Tutor] CT-547: Restyle interactions table #58435
Merged
ebeastlake
merged 7 commits into
staging
from
task/emily/ct-547/restyle-teacher-dashboard
May 7, 2024
Merged
[AI Tutor] CT-547: Restyle interactions table #58435
ebeastlake
merged 7 commits into
staging
from
task/emily/ct-547/restyle-teacher-dashboard
May 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ask/emily/ct-547/restyle-teacher-dashboard
ebeastlake
commented
May 7, 2024
acc.push({label: message.studentName, value: userId}); | ||
} | ||
return acc; | ||
const generateStudentFilterOptions = (messages: StudentChatRow[]) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did two things here:
- Extracted the logic for the student filters into a "generateStudentFilterOptions" helper
- Combined the two
useEffect
blocks
ebeastlake
commented
May 7, 2024
|
||
const messageDate = moment(message.createdAt); | ||
let timeMatch = false; | ||
const isTimeMatch = (createdAt: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The time matching logic didn't change, but adding an isTimeMatch
helper made the chat message filtering logic more readable.
8 tasks
molly-moen
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR:
Table
from 'reactabular-table' that's used elsewhere in the codebaseInteractionsTableRow
, which is no longer needed.tsx
componentBefore:
After (includes SegmentedButton merged to staging):
Links
Jira ticket: https://codedotorg.atlassian.net/browse/CT-545
Testing story
Tested locally.
Deployment strategy
Follow-up work
PR Checklist: