-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI Tutor] CT-547: Restyle teacher dashboard part 2 #58437
Conversation
…ask/emily/ct-547/restyle-teacher-dashboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question on use of any
, otherwise looks good!
cell: { | ||
formatters: [ | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
(aiTutorAccessDenied: boolean, {rowData}: any) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did we need to use any
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I was lazy when I got this working, and I didn't go back 😂 Nice catch!
This PR builds upon what's in #58435 and extends the styling to the "Access Control" area of the dashboard.
Before:
After:
This PR also fixes the spacing between the dropdowns in the Interactions view.
Links
Jira ticket:
Testing story
Tested locally.
Deployment strategy
Follow-up work
Ken has a PR to enable turning on/off access for an entire section. That PR will need to incorporate these changes.
PR Checklist: