Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI Tutor] CT-547: Restyle teacher dashboard part 2 #58437

Merged
merged 11 commits into from
May 8, 2024

Conversation

ebeastlake
Copy link
Contributor

@ebeastlake ebeastlake commented May 7, 2024

This PR builds upon what's in #58435 and extends the styling to the "Access Control" area of the dashboard.

Before:

Screenshot 2024-05-06 at 11 36 33 PM

After:

Screenshot 2024-05-06 at 11 36 04 PM

This PR also fixes the spacing between the dropdowns in the Interactions view.

Screenshot 2024-05-06 at 11 35 57 PM

Links

Jira ticket:

  1. https://codedotorg.atlassian.net/browse/CT-547
  2. https://codedotorg.atlassian.net/browse/CT-546

Testing story

Tested locally.

Deployment strategy

Follow-up work

Ken has a PR to enable turning on/off access for an entire section. That PR will need to incorporate these changes.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ebeastlake ebeastlake changed the base branch from staging to task/emily/ct-547/restyle-teacher-dashboard May 7, 2024 06:39
@ebeastlake ebeastlake requested a review from a team May 7, 2024 06:44
Copy link
Contributor

@molly-moen molly-moen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on use of any, otherwise looks good!

cell: {
formatters: [
// eslint-disable-next-line @typescript-eslint/no-explicit-any
(aiTutorAccessDenied: boolean, {rowData}: any) => (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need to use any here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I was lazy when I got this working, and I didn't go back 😂 Nice catch!

Base automatically changed from task/emily/ct-547/restyle-teacher-dashboard to staging May 7, 2024 23:50
@ebeastlake ebeastlake requested a review from molly-moen May 8, 2024 02:03
@ebeastlake ebeastlake merged commit 4aafe0b into staging May 8, 2024
2 checks passed
@ebeastlake ebeastlake deleted the emily/ct-547/restyle-teacher-dashboard-2 branch May 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants