Added tests for Progress View V2 Invitation #58471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfryemason
reviewed
May 9, 2024
| @@ -34,11 +34,13 @@ function InviteToV2ProgressModal({ | |||
| const [invitationOpen, setInvitationOpen] = React.useState(false); | |||
|
|
|||
| React.useEffect(() => { | |||
| const timeSinceInvitationLastDelayed = () => { | |||
| const numDaysSinceInvitationLastDelayed = () => { | |||
| const MILLISECONDS_IN_ONE_DAY = 1000 * 3600 * 24; | |||
There was a problem hiding this comment.
Nit: move this constant outside the InviteToV2ProgressModal function (to the top of the file).
| it('renders the dialog with required elements', () => { | ||
| renderDefault(); | ||
|
|
||
| expect(screen.getByText(i18n.progressTrackingAnnouncement())).to.exist; |
There was a problem hiding this comment.
Suggested change
| expect(screen.getByText(i18n.progressTrackingAnnouncement())).to.exist; | |
| screen.getByText(i18n.progressTrackingAnnouncement()); |
getByText will throw an error if it is not found. We don't need the expect statement and in fact get a much much better error message if we omit it.
Same for a bunch below.
lfryemason
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test following the PR for the invitation modal to V2 Progress view.
Note: eyes tests will be in future PR
Links