Show half hour on certificates for courses under 30 minutes #58499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We received this Zendesk ticket where a user was seeing "0 minutes" on their certificate for "Teaching CSD Module 1" (a 10-minute intro module). The issue was that the time rounds to the nearest 30 minutes so this rounded down to 0 minutes. This PR fixes this by having any courses that are rounded to "0 minutes" show "30 minutes" instead.
Without fix
With fix
Links
Zendesk ticket: here
Testing story
Local testing.