Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Music: update UI test #58797

Merged
merged 1 commit into from
May 21, 2024
Merged

Music: update UI test #58797

merged 1 commit into from
May 21, 2024

Conversation

breville
Copy link
Member

Update UI test to skip the pack dialog when viewing a standalone Music Lab project.

@breville breville requested review from moneppo and a team May 21, 2024 04:45
@breville breville merged commit efd6fbb into staging May 21, 2024
0 of 2 checks passed
@breville breville deleted the music-update-ui-test branch May 21, 2024 04:46
@@ -220,7 +220,7 @@ const PackDialog: React.FunctionComponent<PackDialogProps> = ({player}) => {
<div className={styles.buttonContainer}>
<button
onClick={setPackToDefault}
className={styles.skip}
className={classNames('skip-button', styles.skip)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be good to rename to something like .ui-test-music-skip-button so it's not accidentally affected by any of the application-wide styles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants