Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music: update UI test #58797

Merged
merged 1 commit into from
May 21, 2024
Merged

Music: update UI test #58797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/src/music/views/PackDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ const PackDialog: React.FunctionComponent<PackDialogProps> = ({player}) => {
<div className={styles.buttonContainer}>
<button
onClick={setPackToDefault}
className={styles.skip}
className={classNames('skip-button', styles.skip)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: might be good to rename to something like .ui-test-music-skip-button so it's not accidentally affected by any of the application-wide styles?

type="button"
>
Skip
Expand Down
3 changes: 3 additions & 0 deletions dashboard/test/ui/features/star_labs/musiclab/musiclab_drag_block.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Scenario Outline: Dragging play sound block
Given I am on "<url>"
And I rotate to landscape

# Skip the pack dialog if it is showing.
Then I click selector ".skip-button" if it exists

# Wait until we see the first category.
And I wait until element ".blocklyTreeRow" is visible

Expand Down