Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update phone number format validation across NGO HUB #468

Closed
anastk-code4 opened this issue Feb 20, 2024 · 2 comments · Fixed by #572 or #580
Closed

Update phone number format validation across NGO HUB #468

anastk-code4 opened this issue Feb 20, 2024 · 2 comments · Fixed by #572 or #580
Assignees
Milestone

Comments

@anastk-code4
Copy link
Contributor

Currently, phone number fields allow only romanian phone number format.
We need to allow international phone number format.

See affected fields in Data Dictionary NGOHUB
NGOADMIN_PHONE
NGO_PHONE
NGO_REPPHONE
NGO_COUNCIL_PHONE
NGO_PPL_PHONE

@dragos1195
Copy link
Contributor

Hello,
@anastk-code4 @mirunaioana-msc

I've created a PR regarding this issue, however, we'll keep a strict validation in the backend, while having a light one for the frontend.

The reasoning for this issue can also be found in the library that we use for the frontend validation:
https://gitlab.com/catamphetamine/react-phone-number-input#isvalidphonenumbervalue-string-boolean

Please confirm that this is alright.
The phone number is still strictly checked in the backend.

@MarG66
Copy link

MarG66 commented Jul 12, 2024

@dragos1195 Testing failed, feature missing picker from:
"Reprezentantul legal al organizației" - Informatii legale
"Consiliul Director al organizației" - Informatii legale
"Persoana de contact în relația cu NGO Hub" - Date generale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment