Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tvOS support #11

Closed
mpospese opened this issue Sep 26, 2022 · 0 comments · Fixed by #12
Closed

Add tvOS support #11

mpospese opened this issue Sep 26, 2022 · 0 comments · Fixed by #12

Comments

@mpospese
Copy link
Contributor

Intro

tvOS uses many of the same UIKit components as iOS, so we should expand Y—CoreUI to support tvOS.

Task

  • add .tvOS(.v14) platform to Swift package
  • Port YCoreUI to compile on tvOS
  • Port YCoreUI to pass unit tests on tvOS
  • Unsupported functionality (if any) should be excluded from tvOS using #if !os(tvOS) or if os(iOS) (keep future watchOS support in mind)
  • Functionality that is supported but does not work (if any) should be excluded from tvOS

AC

  • Project compiles for iOS and tvOS without warnings
  • SwiftLint returns 0 violations
  • All unit tests pass on both platforms
  • 100% documentation coverage of all public interfaces as determined by Jazzy
@mpospese mpospese linked a pull request Sep 26, 2022 that will close this issue
Add tvOS support #12
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tvOS support codeandtheory/YCoreUI
1 participant
@mpospese