Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernizr is nowhere to be found #1880

Closed
7 tasks
asideofcode-dev opened this issue Jul 22, 2023 · 1 comment · Fixed by #1882
Closed
7 tasks

modernizr is nowhere to be found #1880

asideofcode-dev opened this issue Jul 22, 2023 · 1 comment · Fixed by #1882

Comments

@asideofcode-dev
Copy link
Contributor

Description of the issue 📄

There's an include tag for modernizr in the application view template.

= javascript_include_tag 'vendor/modernizr'

Perhaps this used to be available in some earlier version of some gem, but now it's nowhere to be found. If you run the site from scratch you'll notice a 404 for that particular resource in the Javascript console.

I'm a little bit confused about how this file is available in production, though I suspect caching might be to blame.

I also noticed this warning in the logs:

 (called from _app_views_layouts_application_html_haml__4168757267524813890_60640 at /planner/app/views/layouts/application.html.haml:13)
DEPRECATION WARNING: The asset "vendor/modernizr.js" is not present in the asset pipeline.
Falling back to an asset that may be in the public folder.
This behavior is deprecated and will be removed.
To bypass the asset pipeline and preserve this behavior,
use the `skip_pipeline: true` option.

Screenshots 📷

Steps to fix 🛠

Not sure if necessary. Might be a good time to be rid of it.

To do 📋

  • Claim this issue (comment below, or assign yourself if you are part of the codebar org)
  • Fork and clone the repository
  • Update the relevant files. Follow the steps to fix section in this issue.
  • Commit your changes as one commit. Use the title of this issue as your commit message
  • Submit a pull request
  • Mention this issue in the PR description by including it's number
  • Have your pull request reviewed & merged by a codebar team member
@matyikriszta
Copy link
Contributor

@asideofcode-dev if I remember correctly an older version of Foundation we were using required modernizer which is why that line is there. We have now migrated to Bootstrap which does not rely on modernizer (or if it does under the hood it's bundled with the gem and does not have to be imported separately) so this could be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants