Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Registration][Testing] New Registration & Auth Flow Broke "Users" App Tests #192

Open
BethanyG opened this issue Sep 24, 2020 · 4 comments
Labels
bug Something isn't working needs discussion The fix for this issue needs discussion pinned

Comments

@BethanyG
Copy link
Member

The changes in PR #187 once merged will cause the tests under users/tests/ to mostly fail (6 out of 9).

Currently, these are marked skip, but need to be re-written to work (or the app needs to change to make them work).

Failing tests are:

 -   users/tests/test_models.py:7 test_user_get_absolute_url
 -   users/tests/test_urls.py:8 test_detail
 -   users/tests/test_urls.py:16 test_update
 -   users/tests/test_urls.py:21 test_redirect
 -   users/tests/test_views.py:19 TestUserUpdateView.test_get_success_url
 -   users/tests/test_views.py:43 TestUserRedirectView.test_get_redirect_url

Suspect they can mostly be fixed with some URL changes. Since the "users" app is largely unused due to DRF, these were seen as lower-priority tests, and I didn't hold #187 for them.

@BethanyG BethanyG added the bug Something isn't working label Sep 24, 2020
@BethanyG BethanyG changed the title [New User Registration][Testing] New Registration & Auth Flow Broke "Users" App Tests [User Registration][Testing] New Registration & Auth Flow Broke "Users" App Tests Sep 24, 2020
@BethanyG BethanyG added the needs discussion The fix for this issue needs discussion label Sep 25, 2020
@BethanyG
Copy link
Member Author

One overarching question here is do we even want this as an endpoint?? userauth has all of the registration flow and email verifications, should we just add to it for the user profile, or park that functionality here in users??

@stale
Copy link

stale bot commented Oct 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 25, 2020
@BethanyG BethanyG removed the stale label Oct 26, 2020
@stale
Copy link

stale bot commented Nov 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 25, 2020
@BethanyG BethanyG removed the stale label Nov 25, 2020
@BethanyG
Copy link
Member Author

still open

@lpatmo lpatmo added the pinned label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs discussion The fix for this issue needs discussion pinned
Projects
None yet
Development

No branches or pull requests

2 participants