deprecate TO_FILE and make all private methods private #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grosser
force-pushed
the
grosser/env
branch
2 times, most recently
from
b31437e
to
d428cd0
Compare
| expect(formatter.short_filename('file1')).to eq('file1') | ||
| expect(formatter.short_filename("#{::SimpleCov.root}/file1")).to eq('file1') | ||
| expect(call('file1')).to eq('file1') | ||
| expect(call("#{::SimpleCov.root}/file1")).to eq('file1') |
There was a problem hiding this comment.
I think I prefer the explicit style. This is harder for me to read.
There was a problem hiding this comment.
Are these spec changes related to the changes in this commit? They don't seem to be.
There was a problem hiding this comment.
un-dry-ed it
On Sat, Apr 18, 2015 at 7:27 AM, Noah Davis notifications@github.com
wrote:
In spec/lib/formatter_spec.rb
#84 (comment)
:it 'should return the filename of the file relative to the SimpleCov root' do
expect(formatter.short_filename('file1')).to eq('file1')expect(formatter.short_filename("#{::SimpleCov.root}/file1")).to eq('file1')expect(call('file1')).to eq('file1')expect(call("#{::SimpleCov.root}/file1")).to eq('file1')I think I prefer the explicit style. This is harder for me to read.
—
Reply to this email directly or view it on GitHub
https://github.com/codeclimate/ruby-test-reporter/pull/84/files#r28644407
.
|
good to go ? |
| @@ -36,6 +36,8 @@ def format(result) | |||
| false | |||
| end | |||
|
|
|||
| private | |||
There was a problem hiding this comment.
fyi was not outdetend before
|
Looking better, thank you -- one last comment. |
noahd1
added a commit
that referenced
this pull request
Apr 19, 2015
deprecate TO_FILE and make all private methods private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@noahd1 @jonathancadepowers