-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Inventory System #59
Comments
Now that dropping has been added to the inventory system, if you want to pick a thang up, move to a new position, and then drop the thang, the thang must have both the Collectable component added, but also the Moves component (or else the new position is never registered). Should it remain this way (which should then be documented or added as a dependency), or should the Collects component added "pos" as a tracked property of any thang that is dropped? |
We haven't really needed any inventory system extensions for a year, so closing this–the levels I want to make don't need it. |
Along with issues like #48 and #49 to make the item collection/transfer animations cool, we'll also want to add a new inventory display and to improve the support for managing objects in an
inventory.Collects
Thang's inventory.Display
If you add
inventory
to a Thang'sui.Selectable
Component'sextraHUDProperties
configuration:--then you'll see something like this when you select that Thang in the level:
So we have a rudimentary inventory display already, but it doesn't have icon support for the things in the inventory, and it's way too small to make a core part of gameplay. So one thing to do would be to add icons there. Another thing to do, perhaps later, would be to make a separate visual interface for these things to give them the proper weight; I can suggest implementation details if someone suggest a visual design.
Inventory Mechanics
Right now, the
inventory
property of aninventory.Collects
Thang is just an array, and in that array are theid
strings ofinventory.Collectable
Thangs that the collector has collected. That's it. All the logic on top of that is a total hack. Also, when a collectable Thang is collected, it assigns itscollectableProperties
to the collector--you can see the code for that ininventory.Collects
. It's just a hack to get potions to work.We should improve/replace all that code so that we can do things like reference actual Thangs which have been collected, have logic for what it means to have various Thangs in one's inventory, and extend collection to also include dropping / transferring / using / combining collected Thangs.
The text was updated successfully, but these errors were encountered: