Fails on macOS #13
Comments
As Codecov action fails on macOS, see codecov/codecov-action#13
|
Also fails on Windows with the same error. |
|
Build failure is because this is a Docker Action which are only supported on Linux. Porting to a JavaScript Action would resolve the issue because they are supported on Windows, macOS and Linux. https://help.github.com/en/articles/about-actions#types-of-actions |
This commit replaces azure pipelines with github actions, tarpaulin with (cross-platform) grcov, and codecov.io with coveralls.io. Github Actions turned out to be a much better fit for this project. It integrates much better with our already existing workflow, seems more feature complete and is easier to work with. Tarpaulin kept crashing on Azure Pipelines and after trying also with Github Actions, its still under active development so thats not very strange. However, I prefer to have inaccurate code coverage than no coverage at all. Therefor I replaced Tarpaulin with grcov. grcov does report some lines missed that are actually ok but again, its better than nothing. Also, grcov works on all our target platforms so we get better cross platform coverage in return. I replaced codecov.io as our coverage service with coveralls.io. Although I like the interface of codecov better there is no support for uploading reports on macOS and windows. See codecov/codecov-action#13 for more information.
This commit replaces azure pipelines with github actions, tarpaulin with (cross-platform) grcov, and codecov.io with coveralls.io. Github Actions turned out to be a much better fit for this project. It integrates much better with our already existing workflow, seems more feature complete and is easier to work with. Tarpaulin kept crashing on Azure Pipelines and after trying also with Github Actions, its still under active development so thats not very strange. However, I prefer to have inaccurate code coverage than no coverage at all. Therefor I replaced Tarpaulin with grcov. grcov does report some lines missed that are actually ok but again, its better than nothing. Also, grcov works on all our target platforms so we get better cross platform coverage in return. I replaced codecov.io as our coverage service with coveralls.io. Although I like the interface of codecov better there is no support for uploading reports on macOS and windows. See codecov/codecov-action#13 for more information.
This commit replaces azure pipelines with github actions, tarpaulin with (cross-platform) grcov, and codecov.io with coveralls.io. Github Actions turned out to be a much better fit for this project. It integrates much better with our already existing workflow, seems more feature complete and is easier to work with. Tarpaulin kept crashing on Azure Pipelines and after trying also with Github Actions, its still under active development so thats not very strange. However, I prefer to have inaccurate code coverage than no coverage at all. Therefor I replaced Tarpaulin with grcov. grcov does report some lines missed that are actually ok but again, its better than nothing. Also, grcov works on all our target platforms so we get better cross platform coverage in return. I replaced codecov.io as our coverage service with coveralls.io. Although I like the interface of codecov better there is no support for uploading reports on macOS and windows. See codecov/codecov-action#13 for more information.
|
Hi all, Copying my answer from #7 here:
Ib |
|
Looking at your entrypoint https://github.com/codecov/codecov-action/blob/master/entrypoint.sh all your container does is download and then run a binary which you could just as easily do in a JavaScript Action and would give you cross platform support. |
|
@adam7 I'll look this, I wasn't aware that it was possible but perhaps my assumptions are incorrect here. |
|
Maybe you should add |
|
@nklayman I added that line to our readme on this commit Thanks for the suggestion! |
|
Hi all, As of release v1.0.4, we've officially switched to using JavaScript for our action. It is now supported on Linux, macOS, and Windows. Feel free to use it your macOS and matrix builds :D @adam7 Thank you for your initial suggestion! Ib |
macOS build fails:
##[error]Container action is only supported on Linuxhttps://github.com/paulz/ImageCoordinateSpace/commit/4a8530e92f00011b1c8bf8cb1078676b1acc620c/checks#step:5:4
The text was updated successfully, but these errors were encountered: