Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OGUI-416] Run coverage on macos for QCG #400

Merged
merged 11 commits into from
Oct 29, 2019
Merged

[OGUI-416] Run coverage on macos for QCG #400

merged 11 commits into from
Oct 29, 2019

Conversation

graduta
Copy link
Member

@graduta graduta commented Oct 28, 2019 •
edited
Loading

Issues:

  • Our npm coverage is failing on Ubuntu due to known JS out of memory issue and that is why coverage was moved to MacOS
  • CodeCov - GH ACtion is not yet supported on MacOS Fails on macOS codecov/codecov-action#13 and that is why codecov was removed. Bash is supported and also faster.

@graduta graduta self-assigned this Oct 28, 2019
@awegrzyn awegrzyn self-requested a review October 29, 2019 06:59
@graduta graduta merged commit 127e789 into dev Oct 29, 2019
@graduta graduta deleted the bugfix/QCG/OGUI-416-fix-code-coverage-on-qcg branch October 29, 2019 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awegrzyn awegrzyn awegrzyn approved these changes

Assignees

@graduta graduta

Labels
CI Quality Control
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graduta @awegrzyn