This repository has been archived by the owner on Apr 20, 2023. It is now read-only.
CODECOV_* env need to be in tox passenv #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From tox-dev/tox-travis#106 it became clear that the lack of explicit mention in passenv is confusing to the user. They might think that `CODECOV_*` env vars are automatically passed through. As tox only passes through the absolute minimum necessary `CODECOV_*` has to be added to passenv also.
This was referenced Jun 2, 2018
|
I have no idea why that test on appveyor fails, but I would hazard a guess that my change in the README did not cause this 😄 |
|
It would be great to merge that, as it is a simple addition to the README that will save newcomers some trouble 🙇♂️. |
|
@stevepeak maybe you want to invite a few more people to this org, to help with merging trivial PRs like this one? |
|
@stevepeak is this repo still maintained? |
|
Looks good @obestwalter , thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From tox-dev/tox-travis#106 it became clear that the lack of explicit mention in passenv is confusing to the user. They might think that
CODECOV_*env vars are automatically passed through.As tox only passes through the absolute minimum necessary
CODECOV_*has to be added to passenv also.