Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser test coverage, run in content-shell #2

Merged
merged 1 commit into from
Jun 23, 2015

Conversation

evanweible-wf
Copy link
Contributor

Issue

  • It's better to run coverage for browser tests using content-shell
    • Can pipe console logs to stdout
    • Easier integration with Travis CI
  • Browser test run currently doesn't wait properly for tests to finish, resulting in incomplete and inconsistent coverage reporting when running large sets of tests

Changes

Source:

  • Switch from Dartium to content-shell
  • Listen to the test output from content-shell to determine when the tests are finished

Tests:

  • Browser tests added to verify the browser use case

@stevepeak @johnryan-wf

@evanweible-wf
Copy link
Contributor Author

@maxwellpeterson-wf
Copy link

+1

@stevepeak
Copy link

There is the Codecov Bash uploader if that helps. I do prefer it being the uploader for consistency purposes. https://github.com/codecov/codecov-bash

@evanweible-wf
Copy link
Contributor Author

@stevepeak I wasn't aware of that tool, thanks for pointing that out!

@johnryan-wf
Copy link
Contributor

+1

johnryan-wf added a commit that referenced this pull request Jun 23, 2015
Fix browser test coverage, run in content-shell
@johnryan-wf johnryan-wf merged commit b40aad9 into codecov:master Jun 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants