Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: banner not showing in right location #1541

Closed
Tracked by #1540
codecovdesign opened this issue Apr 9, 2024 · 2 comments · Fixed by codecov/gazebo#2859
Closed
Tracked by #1540

BUG: banner not showing in right location #1541

codecovdesign opened this issue Apr 9, 2024 · 2 comments · Fixed by codecov/gazebo#2859
Assignees
@RulaKhaled
Labels
bug Something isn't working

Comments

@codecovdesign
Copy link
Contributor

codecovdesign commented Apr 9, 2024 •
edited
Loading

Problem to solve

Banner location below summary – user may not have visibility. This happened after install codecov to repo during first commit / pr (not merged)

Screenshot 2024-04-09 at 11 12 23 AM

Intended state

  • banner shown above summary below nav for visibility
  • also the summary view is not visible
This was referenced Apr 9, 2024
Open
Open
@codecovdesign codecovdesign added the bug Something isn't working label Apr 9, 2024
@RulaKhaled
Copy link

@codecovdesign when do we usually show this banner?

@codecovdesign
Copy link
Contributor Author

@RulaKhaled intended to be in the summary view and we show it after the repo 1st commit (welcome)

@RulaKhaled RulaKhaled mentioned this issue May 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RulaKhaled RulaKhaled

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Move the banner above summary, and fix the use of team hook codecov/gazebo
2 participants
@codecovdesign @RulaKhaled