Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bundle Caching][API] When doing pull comparison handle head commit not exist #2040

Closed
1 task done
Tracked by #1707
JerrySentry opened this issue Jul 4, 2024 · 0 comments · Fixed by codecov/codecov-api#688
Closed
1 task done
Tracked by #1707
Assignees

Comments

@JerrySentry
Copy link

JerrySentry commented Jul 4, 2024

If a commit never uploaded any bundle stat files (due to all bundles were being cached) we want to show the parent commit's data. In this case when doing the comparison set the head commit to the base commit

In resolve_bundle_analysis_compare_with_base

if not pull.head:
    bundle_analysis_comparison = load_bundle_analysis_comparison(
        Commit.objects.filter(commitid=pull.compared_to).first(),
        Commit.objects.filter(commitid=pull.compared_to).first(),
    )

Note that this could be misleading because after they make a PR but before the uploads are done yet they think there's no change in the bundles

Blocked By

  1. 1 of 1
    JerrySentry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant