Refactor User to contain pill logic and a classes object. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for gazebo ready! Built with commit da8f372 |
Codecov Report
@@ Coverage Diff @@
## main #235 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 74 74
Lines 553 551 -2
=========================================
- Hits 553 551 -2
Continue to review full report at Codecov.
|
Comment on lines
159
to
161
| student={user.student} | ||
| email={user.email} | ||
| isAdmin={user.isAdmin} |
There was a problem hiding this comment.
we could pass user={user} instead of passing all the user information one by one
src/ui/User/User.js
Outdated
Comment on lines
15
to
23
| function createUserPills({ student, isAdmin, email }) { | ||
| const pills = [] | ||
|
|
||
| if (isAdmin) pills.push({ text: 'Admin', highlight: true }) | ||
| if (student) pills.push({ text: 'Student' }) | ||
| if (email) pills.push({ text: email }) | ||
|
|
||
| return pills | ||
| } |
There was a problem hiding this comment.
For the page to manage the admins, I only need to display the pill for the email. I could either not pass the student / isAdmin as prop, but from my previous comment, I suggested to pass the full user object, so it's a bit contradictory.
I think having the pills as prop could give us the greatest flexibility in that case. Or maybe a list of pill we would like to show? pills=['student', 'admin', 'email']
There was a problem hiding this comment.
Problem is some pills can be highlighted / different colors. So a simple array was my initial strategy but doesn't work out for all the designs.... Though I think I just thought of a way to do this elegantly. An array that accepts strings or an object with data...
dorianamouroux
approved these changes
Jan 28, 2021
ajay-sentry
added a commit
that referenced
this pull request
Feb 20, 2024
RulaKhaled
pushed a commit
that referenced
this pull request
Feb 21, 2024
RulaKhaled
added a commit
that referenced
this pull request
Feb 22, 2024
* Update customer intent * adjust to a link * Update default org * Lets move default org * Update with const to enums * redirect to landing page * Update with tests * update to move check to use user access gate * fix: Quick patch for the text alignment (#2603) * Upate with learn more link (#2604) * feat: Add in new formatTimeToString function handling milliseconds (#2600) Add in a new formatTimeToString function that handles milliseconds instead of seconds. GH codecov/engineering-team#1200 * Show next billing date for active accounts in callout view (#2585) * feat: Display list of bundles on head when comparison fails (#2598) When no comparison is present display the head commit bundle details on the PR page. * feat: #235 - Org page CTA Button Update (#2602) * update configure button, fix this prettier file? * convert to TS, add a TS-ignore for applink shenanigans * add new variant class on A tag for configure styling * fix local UTs, add a few new ones for the InactiveRepo component * update spec and small resync styling tweaks (#2609) * Update with link change (#2582) * Just update to use proper links from use Static navs * Update spelling --------- Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com> Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
RulaKhaled
pushed a commit
that referenced
this pull request
Mar 8, 2024
RulaKhaled
added a commit
that referenced
this pull request
Mar 8, 2024
* Update customer intent * adjust to a link * Update default org * Lets move default org * Update with const to enums * redirect to landing page * Update with tests * update to move check to use user access gate * fix: Quick patch for the text alignment (#2603) * Upate with learn more link (#2604) * feat: Add in new formatTimeToString function handling milliseconds (#2600) Add in a new formatTimeToString function that handles milliseconds instead of seconds. GH codecov/engineering-team#1200 * Show next billing date for active accounts in callout view (#2585) * feat: Display list of bundles on head when comparison fails (#2598) When no comparison is present display the head commit bundle details on the PR page. * feat: #235 - Org page CTA Button Update (#2602) * update configure button, fix this prettier file? * convert to TS, add a TS-ignore for applink shenanigans * add new variant class on A tag for configure styling * fix local UTs, add a few new ones for the InactiveRepo component * update spec and small resync styling tweaks (#2609) * Update with link change (#2582) * Just update to use proper links from use Static navs * Update spelling --------- Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com> Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactor User API
Added User story.
Of Note
Wanted folow up work: Pill and Avatar UI component. I think we should make a variant of avatar to control the size of the circle for more flexibility in this component (and the header).
Screenshots