Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Quick patch for the text alignment #2603

Merged
merged 1 commit into from
Feb 20, 2024
Merged

fix: Quick patch for the text alignment #2603

merged 1 commit into from
Feb 20, 2024

Conversation

RulaKhaled
Copy link
Contributor

@RulaKhaled RulaKhaled commented Feb 19, 2024

Description

Screenshot 2024-02-19 at 5 00 26 PM Screenshot 2024-02-19 at 5 00 17 PM

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov-public-qa bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec761ce) 98.35% compared to head (b4541fb) 98.35%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2603   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         831      831           
  Lines       11098    11098           
  Branches     2872     2819   -53     
=======================================
  Hits        10915    10915           
  Misses        181      181           
  Partials        2        2           
Files Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.32% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec761ce...b4541fb. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2603   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         831      831           
  Lines       11098    11098           
  Branches     2819     2872   +53     
=======================================
  Hits        10915    10915           
  Misses        181      181           
  Partials        2        2           
Files Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.32% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec761ce...b4541fb. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec761ce) 98.35% compared to head (b4541fb) 98.35%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2603   +/-   ##
=======================================
  Coverage   98.35%   98.35%           
=======================================
  Files         831      831           
  Lines       11098    11098           
  Branches     2821     2872   +51     
=======================================
  Hits        10915    10915           
  Misses        181      181           
  Partials        2        2           
Files Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.32% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec761ce...b4541fb. Read the comment docs.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for gazebo-staging ready!

Name Link
🔨 Latest commit b4541fb
🔍 Latest deploy log https://app.netlify.com/sites/gazebo-staging/deploys/65d37bcb66a0bb000853c7f1
😎 Deploy Preview https://deploy-preview-2603--gazebo-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ec761ce) 98.35% compared to head (b4541fb) 98.35%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2603   +/-   ##
=====================================
  Coverage   98.35   98.35           
=====================================
  Files        831     831           
  Lines      11098   11098           
  Branches    2854    2864   +10     
=====================================
  Hits       10915   10915           
  Misses       181     181           
  Partials       2       2           
Files Coverage Δ
...lCoverage/routes/ComponentsTab/ComponentsTable.tsx 100.00% <ø> (ø)
Components Coverage Δ
Assets 55.26% <ø> (ø)
Layouts 96.95% <ø> (ø)
Pages 99.32% <ø> (ø)
Services 99.56% <ø> (ø)
Shared 99.83% <ø> (ø)
UI 94.27% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec761ce...b4541fb. Read the comment docs.

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 35 bytes ⬆️

Bundle name Size Change
gazebo-staging-array-push 5.92MB 35 bytes ⬆️

Copy link

codecov bot commented Feb 19, 2024

Bundle Report

Changes will increase total bundle size by 35 bytes ⬆️

Bundle name Size Change
gazebo-production-array-push 5.92MB 35 bytes ⬆️

@codecov-releaser
Copy link
Contributor

Visit https://preview-pr-2603.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2603-enterprise.codecov.dev

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RulaKhaled RulaKhaled merged commit 5abe7f3 into main Feb 20, 2024
62 checks passed
@RulaKhaled RulaKhaled deleted the components-fix branch February 20, 2024 11:20
RulaKhaled added a commit that referenced this pull request Feb 22, 2024
* Update customer intent

* adjust to a link

* Update default org

* Lets move default org

* Update with const to enums

* redirect to landing page

* Update with tests

* update to move check to use user access gate

* fix: Quick patch for the text alignment (#2603)

* Upate with learn more link (#2604)

* feat: Add in new formatTimeToString function handling milliseconds (#2600)

Add in a new formatTimeToString function that handles milliseconds instead of seconds.

GH codecov/engineering-team#1200

* Show next billing date for active accounts in callout view (#2585)

* feat: Display list of bundles on head when comparison fails (#2598)

When no comparison is present display the head commit bundle details on the PR page.

* feat: #235 - Org page CTA Button Update (#2602)

* update configure button, fix this prettier file?

* convert to TS, add a TS-ignore for applink shenanigans

* add new variant class on A tag for configure styling

* fix local UTs, add a few new ones for the InactiveRepo component

* update spec and small resync styling tweaks (#2609)

* Update with link change (#2582)

* Just update to use proper links from use Static navs

* Update spelling

---------

Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>
Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com>
Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
RulaKhaled added a commit that referenced this pull request Mar 8, 2024
* Update customer intent

* adjust to a link

* Update default org

* Lets move default org

* Update with const to enums

* redirect to landing page

* Update with tests

* update to move check to use user access gate

* fix: Quick patch for the text alignment (#2603)

* Upate with learn more link (#2604)

* feat: Add in new formatTimeToString function handling milliseconds (#2600)

Add in a new formatTimeToString function that handles milliseconds instead of seconds.

GH codecov/engineering-team#1200

* Show next billing date for active accounts in callout view (#2585)

* feat: Display list of bundles on head when comparison fails (#2598)

When no comparison is present display the head commit bundle details on the PR page.

* feat: #235 - Org page CTA Button Update (#2602)

* update configure button, fix this prettier file?

* convert to TS, add a TS-ignore for applink shenanigans

* add new variant class on A tag for configure styling

* fix local UTs, add a few new ones for the InactiveRepo component

* update spec and small resync styling tweaks (#2609)

* Update with link change (#2582)

* Just update to use proper links from use Static navs

* Update spelling

---------

Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io>
Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com>
Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants