Fix: Quality of life update for the Resync button #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajay-sentry
requested review from
RulaKhaled,
nicholas-codecov,
JerrySentry,
rohitvinnakota-codecov and
spalmurray-codecov
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 833 833
Lines 11156 11156
Branches 2836 2871 +35
=======================================
Hits 10973 10973
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 833 833
Lines 11156 11156
Branches 2836 2838 +2
=======================================
Hits 10973 10973
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
=======================================
Coverage 98.35% 98.35%
=======================================
Files 833 833
Lines 11156 11156
Branches 2836 2881 +45
=======================================
Hits 10973 10973
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2609 +/- ##
=====================================
Coverage 98.36 98.36
=====================================
Files 833 833
Lines 11156 11156
Branches 2881 2881
=====================================
Hits 10973 10973
Misses 181 181
Partials 2 2
Continue to review full report in Codecov by Sentry.
|
✅ Deploy Preview for gazebo-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle ReportChanges will decrease total bundle size by 13 bytes ⬇️
|
|
Visit https://preview-pr-2609.codecov.dev for your PR preview. Expires after 1 month automatically. Enterprise URL: https://preview-pr-2609-enterprise.codecov.dev |
rohitvinnakota-codecov
approved these changes
Feb 20, 2024
ajay-sentry
commented
Feb 20, 2024
| @@ -28,7 +28,7 @@ function RepoOrgNotFound() { | |||
| <span className="font-semibold text-ds-gray-quinary"> | |||
| Can't find your repo? | |||
| </span>{' '} | |||
| Try <ResyncButton /> | |||
There was a problem hiding this comment.
The meat and potatoes
Bundle ReportChanges will decrease total bundle size by 13 bytes ⬇️
|
RulaKhaled
pushed a commit
that referenced
this pull request
Feb 21, 2024
RulaKhaled
added a commit
that referenced
this pull request
Feb 22, 2024
* Update customer intent * adjust to a link * Update default org * Lets move default org * Update with const to enums * redirect to landing page * Update with tests * update to move check to use user access gate * fix: Quick patch for the text alignment (#2603) * Upate with learn more link (#2604) * feat: Add in new formatTimeToString function handling milliseconds (#2600) Add in a new formatTimeToString function that handles milliseconds instead of seconds. GH codecov/engineering-team#1200 * Show next billing date for active accounts in callout view (#2585) * feat: Display list of bundles on head when comparison fails (#2598) When no comparison is present display the head commit bundle details on the PR page. * feat: #235 - Org page CTA Button Update (#2602) * update configure button, fix this prettier file? * convert to TS, add a TS-ignore for applink shenanigans * add new variant class on A tag for configure styling * fix local UTs, add a few new ones for the InactiveRepo component * update spec and small resync styling tweaks (#2609) * Update with link change (#2582) * Just update to use proper links from use Static navs * Update spelling --------- Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com> Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
RulaKhaled
pushed a commit
that referenced
this pull request
Mar 8, 2024
RulaKhaled
added a commit
that referenced
this pull request
Mar 8, 2024
* Update customer intent * adjust to a link * Update default org * Lets move default org * Update with const to enums * redirect to landing page * Update with tests * update to move check to use user access gate * fix: Quick patch for the text alignment (#2603) * Upate with learn more link (#2604) * feat: Add in new formatTimeToString function handling milliseconds (#2600) Add in a new formatTimeToString function that handles milliseconds instead of seconds. GH codecov/engineering-team#1200 * Show next billing date for active accounts in callout view (#2585) * feat: Display list of bundles on head when comparison fails (#2598) When no comparison is present display the head commit bundle details on the PR page. * feat: #235 - Org page CTA Button Update (#2602) * update configure button, fix this prettier file? * convert to TS, add a TS-ignore for applink shenanigans * add new variant class on A tag for configure styling * fix local UTs, add a few new ones for the InactiveRepo component * update spec and small resync styling tweaks (#2609) * Update with link change (#2582) * Just update to use proper links from use Static navs * Update spelling --------- Co-authored-by: nicholas-codecov <nicholas.deschenes@sentry.io> Co-authored-by: Rohit Vinnakota <148245014+rohitvinnakota-codecov@users.noreply.github.com> Co-authored-by: ajay-sentry <159853603+ajay-sentry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small update to "Resync" throughout the codebase from "re-sync" to "Resync."
Main update includes modifying the "main" repos page Resync button from "Try Re-syincing" to "Resync"
Screenshots
Screen.Recording.2024-02-20.at.10.54.15.AM.mov
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.