Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CESD-492] always use block list #512

Merged
merged 6 commits into from
Nov 17, 2021

Conversation

drazisil-codecov
Copy link
Contributor

Closes #504
Renames blocklist

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #512 (1bba9e8) into master (38a46e6) will decrease coverage by 0.24%.
The diff coverage is 87.87%.

@@            Coverage Diff             @@
##           master     #512      +/-   ##
==========================================
- Coverage   93.99%   93.75%   -0.25%     
==========================================
  Files          28       28              
  Lines         949      976      +27     
  Branches      189      193       +4     
==========================================
+ Hits          892      915      +23     
- Misses         25       27       +2     
- Partials       32       34       +2     
Flag Coverage Δ
alpine 93.75% <87.87%> (-0.25%) ⬇️
alpine-proxy 93.75% <87.87%> (-0.25%) ⬇️
alpine-without-git 93.75% <87.87%> (-0.25%) ⬇️
linux 93.75% <87.87%> (-0.25%) ⬇️
linux-without-git 93.75% <87.87%> (-0.25%) ⬇️
macos 93.75% <87.87%> (-0.25%) ⬇️
macos-without-git 93.75% <87.87%> (-0.25%) ⬇️
windows 93.75% <87.87%> (-0.25%) ⬇️
windows-without-git 93.75% <87.87%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 78.84% <50.00%> (-1.74%) ⬇️
src/helpers/files.ts 94.73% <87.50%> (-2.09%) ⬇️
src/helpers/logger.ts 100.00% <100.00%> (ø)

@lgtm-com
Copy link

lgtm-com bot commented Nov 17, 2021

This pull request introduces 1 alert when merging 3582439 into b2a7e35 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

src/helpers/logger.ts Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Show resolved Hide resolved
test/helpers/files.test.ts Outdated Show resolved Hide resolved
src/helpers/files.ts Outdated Show resolved Hide resolved
src/helpers/files.ts Outdated Show resolved Hide resolved
src/helpers/files.ts Show resolved Hide resolved
@drazisil-codecov drazisil-codecov merged commit df0180f into master Nov 17, 2021
@drazisil-codecov drazisil-codecov deleted the CESD-492-always-use-block-list branch November 17, 2021 18:49
@drazisil-codecov drazisil-codecov mentioned this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CESD-492] Uploader should always use it's block list
2 participants