add option to check and warn or bail out on flowtext

[oberstet]

This fixes #49 in a pragmatic way

[Ede123]

Right now it does not really matter (as it seems we don't touch flowRoots, even if they are empty) but in general I guess "compatibility checks" should be done somewhere at the end of scourString() as we most likely want to check Scours output for compatibility, not the input?

[oberstet]

In general, I agree.

In this case, why do all the hard work processing/cleansing the SVG, when we bail out anyway.

[Ede123]

Why don't you include your tests in testscour.py? This will make it easier to keep track of functionality in future.

Also unittests should be minimal examples. Your SVG test files include a lot of unnecessary Inkscape cruft that has nothing to do with the actual test making it harder to find the cause of an issue if something breaks in future.

[oberstet]

Also unittests should be minimal examples

No. The should be as close to real world as possible. And that (foten) means, the input file comes from Inkscape (saved as Inkscape SVG). Because designers just press save.

Why don't you include your tests in testscour.py?

That's a good point. I will fix that, though it'll require some refactoring .. scour doesn't use exceptions at all! And the unit test don't spawn the scour executable, but call directly into the Python module, so we can't test for exit code 1.

[Ede123]

No. The should be as close to real world as possible.

Well, I guess these are two different philosophies, both having advantages and disadvantages.
The most annoying problem with huge test files is that they often cause false positives when something totally unrelated changes (especially if the test conditions are not well defined) which is likely to cause unnecessary work.

That's a good point. I will fix that, though it'll require some refactoring .. scour doesn't use exceptions at all! And the unit test don't spawn the scour executable, but call directly into the Python module, so we can't test for exit code 1.

Yes, I see the need for a solution here, too, to check things like using file streams as input arguments. As you wrote we mainly test functionality in scourString(), but not the actual call of scour on the command line.

[oberstet]

@Ede123 alright. unit tests added. I have only added minimal code .. no big refactoring. Too much work. Whitespace/PEP8 is also annoying and we should clean that up some time ..

[oberstet]

FWIW, the whitespace commit in above only fixes trailing spaces .. the file contains tabs (probably even a mixture of spaces and tabs).

Many Python projects use this rule: indent == 4 spaces (no tabs). But PEP8 has more to say about whitespace ..