Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric 1.x -> 2.x upgrade #210

Closed
gregharvey opened this issue Jun 1, 2018 · 3 comments
Closed

Fabric 1.x -> 2.x upgrade #210

gregharvey opened this issue Jun 1, 2018 · 3 comments

Comments

@gregharvey
Copy link
Member

It's the big one! But we got to do it... :-)

I'll set up a feature branch for this in the mainline repo and also get Python 3/Fabric 2 installed on a staging server so we can start tackling this.

@gregharvey
Copy link
Member Author

gregharvey commented Jun 1, 2018

Note, all functions in Fabric 2 need to have the first argument reserved for context, e.g.

def generate_magento_cron(repo, buildtype, site_link):

Becomes:

def generate_magento_cron(c, repo, buildtype, site_link):

You still call it with just repo, buildtype and site_link though. See FAQ.

@gregharvey
Copy link
Member Author

Superseded by #241.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant