-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/var/www defined explicitly as the webroot #22
Comments
This is a good idea, we'll definitely do it. I'll look into how much we need to change. |
There's a few occurrences! :-D Not sure we'll be able to regex find and replace for them, the easy bit is replacing
|
I haven't done a lot of testing, but it looks like the latest updates (i.e. the one where lots of shell scripts were deprecated) has effectively solved this issue for us. I suppose having /var/www hardcoded is still something that should be fixed, but it's a lot less urgent now from our point of view. |
Thanks for the update, Marc. I'd still like to fix this, indeed. :-) |
/var/www is explicitly defined as the webroot throughout these scripts.
This is fine most of the time, but does cause issues with the remove_old_builds script as on our server /var/www is a symlink to /srv/www and this causes the find command in that script to fail.
Ideally, we could pass the webroot in as a parameter (with /var/www as a fallback).
I'll try and raise a PR for this if/when I get time, but there are about 300 or so instances that will need changing!
The text was updated successfully, but these errors were encountered: