Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link/button is not visible on report page #178

Closed
schlos opened this issue Nov 24, 2021 · 4 comments
Closed

Update link/button is not visible on report page #178

schlos opened this issue Nov 24, 2021 · 4 comments
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Nov 24, 2021

Describe the bug

When viewing a report (report details page), update button ("Ažuriraj") is not visible.

For comparison:
Update button ("Ažuriraj") is visible if there are already other updates/comments added.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

As per figma.

Screenshots

Current - report without comments - missing Update / "Ažuriraj" button:

Screenshot from 2021-11-24 11-46-11

Current - for comparison - report with comments - Update / "Ažuriraj" button is visible:

Screenshot from 2021-11-24 11-45-50

Expected (Figma design):

https://www.figma.com/proto/OrvZfg5BsfdOzeL7nhRpEI/Popravi.to?node-id=3148%3A11297&scaling=min-zoom&page-id=25%3A186&hide-ui=1

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

@schlos schlos added 🕷️ bug Something isn't working help wanted Extra attention is needed ⚡ priority Something that is very urgent html/css labels Nov 24, 2021
@schlos schlos added this to Backlog in Popravi.to priorities via automation Nov 24, 2021
@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

@schlos
Copy link
Member Author

schlos commented Dec 12, 2021

Temporary fixed by adding button next to the Title.

@schlos schlos removed the ⚡ priority Something that is very urgent label Dec 12, 2021
@znmustic
Copy link

@schlos ovo preuzimam :)

@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

Fixed with the pull request #192.

  • added "provide an update" form below the report

Screenshot from 2023-06-12 09-46-06

Screenshot from 2023-06-12 09-46-37

Screenshot from 2023-06-12 10-22-28

Screenshot from 2023-06-12 10-22-15

  • for comparison, our current production theme shows the same update form:

Screenshot from 2023-06-12 10-23-42

@schlos schlos closed this as completed Jun 12, 2023
Popravi.to priorities automation moved this from Backlog to Done Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css
Development

No branches or pull requests

2 participants