Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu cannot be closed if opened on mobile #174

Closed
schlos opened this issue Nov 11, 2021 · 5 comments
Closed

Menu cannot be closed if opened on mobile #174

schlos opened this issue Nov 11, 2021 · 5 comments
Assignees
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css

Comments

@schlos
Copy link
Member

schlos commented Nov 11, 2021

Describe the bug

Mobile menu was broken when fixing desktop menu position (see #103).
Menu cannot be closed if opened on mobile.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Menu should be displayed below menu hamburger icon. Menu should be possible to close by clicking on hamburger icon.
By fixing this we should not revert fix made for desktop: #103.

Screenshots

photo_2021-11-11_22-22-26

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

@schlos schlos added 🕷️ bug Something isn't working help wanted Extra attention is needed html/css labels Nov 11, 2021
@schlos
Copy link
Member Author

schlos commented Nov 26, 2021

How to contribute?
Read our contribution guidelines at https://codeforcroatia.org/popravito-contribution-guidelines.

@schlos schlos changed the title popravito: Menu cannot be closed if opened on mobile Menu cannot be closed if opened on mobile Nov 26, 2021
@znmustic
Copy link

znmustic commented Jun 6, 2023

Preuzela i ovo :)

@schlos
Copy link
Member Author

schlos commented Jun 12, 2023

Test report:

photo_2023-06-12_10-10-06

photo_2023-06-12_10-10-02

photo_2023-06-12_10-11-21

photo_2023-06-12_10-11-18

photo_2023-06-12_10-12-54

Menu icon is now moved outside of the screen, although issue is fixed and menu button is visible when menu is opened, and can be closed by clicking the menu icon again.

@znmustic, fix for this would be to move menu position back to the visible part of the screen (top right part of the mobile screen). How does that sound?

An improvement, if possible would be to show "X" instead of the menu hamburger icon for the menu close action. I.e. X button would be as big as hamburger icon. Let us know if you need a Figma design for this, and we will ask designer to take a look.

@znmustic
Copy link

I did what you asked, I think that now is all good. Just made a pull for fix #194 so you can check it and tell if needed anything more.

@schlos schlos mentioned this issue Jun 13, 2023
5 tasks
@schlos
Copy link
Member Author

schlos commented Jun 13, 2023

Fixed via #194

Screenshots after the fix:

photo_2023-06-13_16-08-19
photo_2023-06-13_16-08-16

@schlos schlos closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working help wanted Extra attention is needed html/css
Projects
Development

No branches or pull requests

2 participants