Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Library List for OBJECT BROWSER and DATABASE BROWSER #65

Closed
Nope7 opened this issue Mar 2, 2021 · 4 comments
Closed

Different Library List for OBJECT BROWSER and DATABASE BROWSER #65

Nope7 opened this issue Mar 2, 2021 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Nope7
Copy link

Nope7 commented Mar 2, 2021

As I wrote in the object, I think that the lists should be different:

  • On the list used by the OBJECT BROWSER I should put the libraries in which I store my compiled programs
  • On the list used by the DATABASE BROWSER I should put the libraries in which I store my tables and my datas

Is it correct or did I misunderstood how to use the extension?

Thanks in advance for your great job

@worksofliam
Copy link
Contributor

Right now, the object browser and database browser both use the library list for the library/schema list. This can change

@worksofliam
Copy link
Contributor

I will separate those lists out after the changes for #60 has been fixed+merged. Thanks!

@worksofliam worksofliam self-assigned this Mar 2, 2021
@worksofliam worksofliam added the enhancement New feature or request label Mar 2, 2021
@worksofliam worksofliam removed their assignment Mar 2, 2021
@worksofliam
Copy link
Contributor

Now that different connections get their own settings, this will be possible. Below is a list of changes required. I will get around to it eventually, but here is a list of what's required if someone else does. Thanks!

Object Browser

  • New connection propertyobjectLibraryList for a list of libraries used by the Object Browser
  • Object Browser needs buttons to add to that libraries list
  • Object Browser needs context menu items to remove libraries (Right click on library -> Remove from list)

Database Browser

  • New connection propertyschemaList for a list of libraries used by the Database Browser
  • Database Browser needs buttons to add to that schemas list
  • Database Browser needs context menu items to remove schemas (Right click on library -> Remove from list)

Configuration additions

  • objectLibraryList and schemaList both need to be added to the code-for-ibmi.connectionSettings array properties in package.json (with defaults)
  • Configuration class needs to include these two properties in the class constructor (with the same defaults). For example:
this.objectLibraryList = base.objectLibraryList || [`QSYS2`];
this.schemaList = base.objectLibraryList || [`SAMPLE`, `QIWS`];

@worksofliam worksofliam added the help wanted Extra attention is needed label Mar 2, 2021
@worksofliam
Copy link
Contributor

I did it! 0.2.4 includes this fix. Object browser and database browser now get their own settings instead of using the library list.

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants