Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discovery] - Landing page styling adjustments #635

Closed
andycwilliams opened this issue May 18, 2024 · 0 comments · Fixed by #658
Closed

[Discovery] - Landing page styling adjustments #635

andycwilliams opened this issue May 18, 2024 · 0 comments · Fixed by #658
Assignees
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features

Comments

@andycwilliams
Copy link
Member

Describe the Current Behavior/Feature:

A few possible, small adjustments. Each one is related to KeyFeatures.jsx.

  1. The primary theme color has changed from a green to a blue, but the images used on the landing page have not been updated.
  2. Refactor the icons to fit on smaller screens. Currently, at least one icon looks strangely to the side when on a mobile viewport.
  3. Several minor optimizations for Material UI. See below for specifics.

On a small viewport:
IconIsKindOfOffCenterAndImagesAreStillGreen

On a slightly larger viewport:
2024-05-17 (3)

Rationale:

  1. The images should continue to match the theme.
  2. Minor visual improvement.
  3. Helps maintain consistency, matching how styling is handled elsewhere.

Proposed Changes:

  1. Replace the images with versions that match the theme.
  2. Could possibly make them conditionally render as a column rather than a row. Or by adjusting the titles themselves.
  3. Line 40 in KeyFeatures.jsx can be refactored from using <strong> to simply adding fontWeight in the Typography sx. Additionally, in Material UI components marginBottom can be simplified as mb (lines 27 and 48).
@andycwilliams andycwilliams added enhancement Enhancement of existing features discovery Open discussion and exploration of topic on hand labels May 18, 2024
@dbmzzo dbmzzo linked a pull request Jun 28, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discovery Open discussion and exploration of topic on hand enhancement Enhancement of existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants