Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup CircleCI to obtain lighthouse report. This can be done by these steps: (1) Run yarn build to generate a built bundle (2) Start a temporary web server. (3) Run lighthouse CLI to obtain... #40

Open
0pdd opened this issue Mar 19, 2019 · 2 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@0pdd
Copy link

0pdd commented Mar 19, 2019

The puzzle 1-5d825f1e from #1 has to be resolved:

https://github.com/codeforthailand/election-live/blob/07762ca9a76792d7a6a37b927c0ac6c676f7dc34/.circleci/config.yml#L44-L49

The puzzle was created by Thai Pangsakulyanont on 19-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd 0pdd mentioned this issue Mar 19, 2019
@dtinth dtinth added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 19, 2019
@z3niths
Copy link

z3niths commented Mar 24, 2019

Do you have a staging environment for the project?
Best scenario would be we run lighthouse using staging server URL after staging was deployed by CI.

Otherwise, we can run it using ci's local server (This still not guarantee about server environment).

@dtinth
Copy link
Contributor

dtinth commented Mar 24, 2019

@z3niths Unfortunately, we don’t have it krub...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants