Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes: Fix warnings, and pry-byebug to dev Gemfile and tweak rubocop execution #127

Merged
merged 4 commits into from
Aug 26, 2017
Merged

Minor fixes: Fix warnings, and pry-byebug to dev Gemfile and tweak rubocop execution #127

merged 4 commits into from
Aug 26, 2017

Commits on Aug 26, 2017

  1. Fix more instance variable not initialized warnings 

    Since EntryPoint does not call Link#initialize, we must make sure to
initialize all of Link's instance variables to avoid any warnings.
    @ivoanjo
    ivoanjo committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    203ce80 View commit details
    Browse the repository at this point in the history

  2. Add pry-byebug to development group, to ease debugging

    @ivoanjo
    ivoanjo committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    e2da5c2 View commit details
    Browse the repository at this point in the history

  3. Switch rubocop task to execute after the tests 

    When you're developing, you're testing and haven't yet settled on the
final state of the code so rubocop telling you you have some extra
spaces somewhere when you're trying to run the test suite is not very
useful.

Instead, let's run the specs first and rubocop afterwards.
    @ivoanjo
    ivoanjo committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    5c0ff41 View commit details
    Browse the repository at this point in the history

  4. Update CHANGELOG

    @ivoanjo
    ivoanjo committed Aug 26, 2017
    Configuration menu
    Copy the full SHA
    7969004 View commit details
    Browse the repository at this point in the history