Minor fixes: Fix warnings, and pry-byebug to dev Gemfile and tweak rubocop execution #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since EntryPoint does not call Link#initialize, we must make sure to initialize all of Link's instance variables to avoid any warnings.
When you're developing, you're testing and haven't yet settled on the final state of the code so rubocop telling you you have some extra spaces somewhere when you're trying to run the test suite is not very useful. Instead, let's run the specs first and rubocop afterwards.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes three minor fixes/tweaks. See the individual commits for more details.