Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes: Fix warnings, and pry-byebug to dev Gemfile and tweak rubocop execution #127

Merged
merged 4 commits into from
Aug 26, 2017
Merged

Minor fixes: Fix warnings, and pry-byebug to dev Gemfile and tweak rubocop execution #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
203ce80
Fix more instance variable not initialized warnings
ivoanjo Aug 26, 2017
e2da5c2
Add pry-byebug to development group, to ease debugging
ivoanjo Aug 26, 2017
5c0ff41
Switch rubocop task to execute after the tests
ivoanjo Aug 26, 2017
7969004
Update CHANGELOG
ivoanjo Aug 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* [#122](https://github.com/codegram/hyperclient/pull/122): Improve error message when server returns invalid data - [@ivoanjo](https://github.com/ivoanjo).
* [#125](https://github.com/codegram/hyperclient/pull/125): Add table of contents to readme and add note asking users to add their projects to the wiki - [@ivoanjo](https://github.com/ivoanjo).
* [#127](https://github.com/codegram/hyperclient/pull/127): Minor fixes: Fix warnings, and pry-byebug to dev Gemfile and tweak rubocop execution - [@ivoanjo](https://github.com/ivoanjo).
* Your contribution here.

### 0.8.5 (July 5, 2017)
Expand Down
1 change: 1 addition & 0 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ group :development do
gem 'guard-minitest'
gem 'guard-spinach'
gem 'pry'
gem 'pry-byebug', platforms: :ruby
end

group :development, :test do
Expand Down
2 changes: 1 addition & 1 deletion Rakefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ end
require 'rubocop/rake_task'
RuboCop::RakeTask.new(:rubocop)

task default: [:rubocop, :test, :spinach]
task default: [:test, :spinach, :rubocop]
2 changes: 2 additions & 0 deletions lib/hyperclient/entry_point.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ def initialize(url, &_block)
@options = { async: true }
@connection = nil
@resource = nil
@key = nil
@uri_variables = nil
yield self if block_given?
end

Expand Down