Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

Fix grunt errors #30

Closed
rodica-andronache opened this issue Sep 12, 2016 · 1 comment
Closed

Fix grunt errors #30

rodica-andronache opened this issue Sep 12, 2016 · 1 comment
Assignees

Comments

@rodica-andronache
Copy link
Contributor

rodica-andronache commented Sep 12, 2016

We need to be careful not to change strings and text domains, to not influence the wp.org translations

rodica-andronache added a commit that referenced this issue Dec 12, 2016
@rodica-andronache rodica-andronache changed the title Configure grunt Fix grunt errors Dec 12, 2016
@rodica-andronache
Copy link
Contributor Author

rodica-andronache commented Dec 15, 2016

@cristian-ungureanu I got some warnings in the sidebar

Notice: Undefined index: before_widget in C:\wamp64\www\wordpress\wp-content\themes\amadeus\widgets\recent-comments.php on line 71

Notice: Undefined index: before_title in C:\wamp64\www\wordpress\wp-content\themes\amadeus\widgets\recent-comments.php on line 73

Notice: Undefined index: after_title in C:\wamp64\www\wordpress\wp-content\themes\amadeus\widgets\recent-comments.php on line 73

Notice: Undefined index: after_widget in C:\wamp64\www\wordpress\wp-content\themes\amadeus\widgets\recent-comments.php on line 87

http://prntscr.com/djr4pr

I think you should first check if those values exists, before using them

Also, please make sure you always create a pull request with your changes :)

rodica-andronache added a commit that referenced this issue Dec 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants