Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labeler is breaking our dont merge label to two seperate ones #10

Closed
riki-gertzik opened this issue Apr 13, 2020 · 10 comments · Fixed by #11
Closed

Labeler is breaking our dont merge label to two seperate ones #10

riki-gertzik opened this issue Apr 13, 2020 · 10 comments · Fixed by #11
Assignees
@rgomezcasas
Labels
🐛 bug Something isn't working

Comments

@riki-gertzik
Copy link

when labeler is executing and pr has a "dont merge" label, the labeler is breaking it into two gray labels - "dont" and "merge"
Any idea why?

image
(I changed to uppercase L)

Thanks in advance!
@rgomezcasas rgomezcasas self-assigned this Apr 15, 2020
@rgomezcasas rgomezcasas added the 🐛 bug Something isn't working label Apr 15, 2020
@gasigo
Copy link

gasigo commented Apr 22, 2020

I'm facing the same issue on my repository.

@riki-gertzik
Copy link
Author

riki-gertzik commented Apr 22, 2020 •
edited
Loading

@gasigo for now I fixed this issue by changing to dont-merge without spaces

@rgomezcasas
Copy link
Member

During this week we'll fix it! :)

@gasigo
Copy link

gasigo commented Apr 24, 2020

Not sure if it's related to this bug, but now I can see that the label is not being added for every PR. If the PR contains a label with more than one word, the size label is never added.

@rgomezcasas rgomezcasas mentioned this issue Apr 27, 2020
Merged
@rgomezcasas
Copy link
Member

Fixed in #11 and released overwriting the v1 release.

Can you verify it? :)

@gasigo
Copy link

gasigo commented Apr 28, 2020

It doesn't seem to add the tag anymore. I've opened a PR two hours ago.

@gasigo
Copy link

gasigo commented Apr 28, 2020

I meant it doesn't add the size tag anymore. But it also doesn't break the other tags.

@rgomezcasas
Copy link
Member

Could you try again?

@rgomezcasas rgomezcasas reopened this Apr 28, 2020
@gasigo
Copy link

gasigo commented Apr 28, 2020

Just tested it again, seems to be working now.

@rgomezcasas
Copy link
Member

Cool!

Have a nice coding!! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgomezcasas rgomezcasas

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[bugfix] Allow labels with spaces CodelyTV/pr-size-labeler
3 participants
@rgomezcasas @gasigo @riki-gertzik