Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webkit: Zero-width characters present if textWrapping=false #25

Closed
willmoffat opened this issue Nov 3, 2010 · 3 comments
Closed

Webkit: Zero-width characters present if textWrapping=false #25

willmoffat opened this issue Nov 3, 2010 · 3 comments

Comments

@willmoffat
Copy link
Contributor

\u200b chars are not removed if textWrapping is false.

To reproduce:

  • visit http://codemirror.net/jstest.html
  • run this JS in the console:

    editor.mirror.setTextWrapping(false);
    /\u200b/.test(editor.mirror.getCode()) // --> false
  • Move the cursor to the end of a line
  • Press Enter

    /\u200b/.test(editor.mirror.getCode()) // --> true

These chars break indentation.

@mzero
Copy link

mzero commented Nov 4, 2010

Aha - this may be the same issue I was seeing as reported in the google group. I also had testWrapping set to false.

@marijnh
Copy link
Member

marijnh commented Nov 4, 2010

Hey Will,

Yeah this is an unintended side effect of my workaround for https://bugs.webkit.org/show_bug.cgi?id=47806 . Now, thank me, for I just spent at least three hours blindly experimenting to find another workaround. I pushed something ( 3798a65 ) that seems to do the trick. If things continue this way, it'll soon be more efficient to dive into the webkit code and fix their bugs for them, rather than work around stuff on our side.

So long,
Marijn

@willmoffat
Copy link
Contributor Author

Hi Marijn, thanks for looking at this. Unfortunately now I'm seeing https://bugs.webkit.org/show_bug.cgi?id=23474 again, but only on my site, not in your demos. Investigating further...

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants