Feat: embedded REST proxy and web console server #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmacvicar
force-pushed
the
feat/embedded-rest-proxy
branch
2 times, most recently
from
3592aeb
to
bb2d515
Compare
jeroiraz
previously approved these changes
May 7, 2021
…PC client Note that the generated gateway code has a comment about this: // RegisterImmuServiceHandlerServer registers the http handlers for service ImmuService to "mux". // UnaryRPC :call ImmuServiceServer directly. // StreamingRPC :currently unsupported pending grpc/grpc-go#906. // Note that using this registration option will cause many gRPC library features to stop working. Consider using RegisterImmuServiceHandlerFromEndpoint instead. func RegisterImmuServiceHandlerServer(ctx context.Context, mux *runtime.ServeMux, server ImmuServiceServer) error {
dmacvicar
force-pushed
the
feat/embedded-rest-proxy
branch
from
37ec703
to
ab04363
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to start a REST API server which proxies the gRPC API ('/api` on :8080)
If built with
make WEBCONSOLE=1, the frontendcode is embedded using statik and served on/. This is automatically configured via build tags. If no tag or make option is given, the webconsole is not setup.So it goes like this:
The option is called WebServer, as I did not want to be more granular about the API and the web console. They use the same server and port.
Missing in draft:
Figure how to use the gRPC TLS configuration for the proxy (get rid ofgrpc.WithInsecure())Not using a gRPC client anymore. Using ImmuServiceServer directly
Notes
The way I figure out where to connect for the gRPC API is simple: if we bind to 0.0.0.0, I use 127.0.0.1. If not, I use the address bind address as specified by the user.there is no client connection anymore. ImmuServiceServer is used.