Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pkg/server): tls configuration is moved in command package from server #735

Merged
merged 5 commits into from
May 7, 2021

Conversation

mmeloni
Copy link
Contributor

@mmeloni mmeloni commented May 7, 2021

Tls configuration is moved inside command package.
Immudb ux now is the follow:

if certificate and pkey are provided they are injected in tls config

if mtls flag is provided certificate authority is mandatory and can be provided with --clientcas flag.

Example on how to setup mtls between immudb and immuclient:

Generate ssl artifacts with

./tools/mtls/generate.sh localhost secretpassword

Launch immudb :

./immudb --mtls --pkey ./tools/mtls/3_application/private/localhost.key.pem --certificate ./tools/mtls/3_application/certs/localhost.cert.pem --clientcas ./tools/mtls/2_intermediate/certs/ca-chain.cert.pem

Launch immuclient with:

./immuclient --mtls --servername localhost --pkey ./tools/mtls/4_client/private/localhost.key.pem --certificate ./tools/mtls/4_client/certs/localhost.cert.pem --clientcas ./tools/mtls/2_intermediate/certs/ca-chain.cert.pem login immudb

@mmeloni mmeloni force-pushed the chore/expose-tls branch 2 times, most recently from ef25cfc to 468972d Compare May 7, 2021 12:56
@mmeloni mmeloni marked this pull request as draft May 7, 2021 12:56
…rom server

Signed-off-by: Michele Meloni <cleaversdev@gmail.com>
cmd/immudb/command/init.go Outdated Show resolved Hide resolved
pkg/server/options.go Outdated Show resolved Hide resolved
Signed-off-by: Michele Meloni <cleaversdev@gmail.com>
Signed-off-by: Michele Meloni <cleaversdev@gmail.com>
@coveralls
Copy link
Collaborator

coveralls commented May 7, 2021

Coverage Status

Coverage decreased (-0.0007%) to 87.517% when pulling ff20bdc on chore/expose-tls into 0d3d91e on master.

Signed-off-by: Michele Meloni <cleaversdev@gmail.com>
@mmeloni mmeloni marked this pull request as ready for review May 7, 2021 15:33
@mmeloni mmeloni requested review from dmacvicar and jeroiraz May 7, 2021 15:33
Signed-off-by: Michele Meloni <cleaversdev@gmail.com>
@mmeloni mmeloni merged commit 8a73ab4 into master May 7, 2021
@mmeloni mmeloni deleted the chore/expose-tls branch May 7, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants