Empty id and class atrributes

[revdan]

I'm using sinatra-simple-navigation 3.5.1 and if I don't specify an id or class in the navigation.rb config file, it's generating <ul id=' ' class=' '>

I've checked the documentation but can't find anything - am I doing something wrong?

[mjtko]

Hi @revdan,

The Sinatra adapter is not currently intelligent enough to suppress rendering of attributes with nil values.

This could be fixed in two ways

1. have the list renderer not specify the :id and :class keys if there are no values defined for them.
2. add intelligence to the #to_attributes method in the sinatra adapter to only render attributes which have non-nil values.

Of course, this should have no effect on your application anyway, and I would consider this to be a purely cosmetic change.

Cheers,

Mark.

[revdan]

Hi Mark,

Thanks for the swift response. It was setting off my OCD ;)

Thanks,
Dan

[mjtko]

Ah, that is something I can certainly appreciate! :-)

I'm going to reopen this and will spend a few minutes fixing it in master a little later today. Will be in the next release!

Cheers,

Mark.

[revdan]

Cheers Mark :)

I noticed this isn't happening on the demo page - is this specific to the Sinatra version?

[mjtko]

Yes, it is specific to the Sinatra adapter - the Rails adapter delegates all content_tag work to the underlying framework. Sinatra doesn't contain as much magic as Rails (which is, of course, the point of Sinatra!) so, the Sinatra adapter contains a trivial content_tag implementation.

[mjtko]

Ok, fixed in c956410, will be out when I get round to making a 3.8.0 release - hope your OCD can wait until then! :-)

Cheers,

Mark.