Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uninitialized variable @dom_attributes warning #218

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Fix uninitialized variable @dom_attributes warning #218

merged 1 commit into from
Mar 6, 2019

Conversation

johantell
Copy link
Contributor

@johantell johantell commented Mar 5, 2019

Background:
The line

(@dom_attributes || {}).merge(dom_id_and_class)

in ItemContainer
printed warnings for usage of unitialized instance variable.

simple-navigation/lib/simple_navigation/item_container.rb:27: warning: instance variable @dom_attributes not initialized

This change will simply fix the issue and remove the warning

Changes:

  • Initialize @dom_attributes in initialize

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.616% when pulling 9195cb0 on johantell:fix_warning into abadde3 on codeplant:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.616% when pulling 9195cb0 on johantell:fix_warning into abadde3 on codeplant:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 99.616% when pulling 9195cb0 on johantell:fix_warning into abadde3 on codeplant:master.

@andi andi merged commit ada3631 into codeplant:master Mar 6, 2019
@johantell johantell deleted the fix_warning branch March 6, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants