Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal text unreadable after page load, since update to 3.10 #3346

Closed
fuse314 opened this issue May 11, 2021 · 9 comments
Closed

terminal text unreadable after page load, since update to 3.10 #3346

fuse314 opened this issue May 11, 2021 · 9 comments
Labels
upstream Needs to be fixed upstream

Comments

@fuse314
Copy link

fuse314 commented May 11, 2021

OS/Web Information

  • Web Browser: Brave Version 1.24.82 Chromium: 90.0.4430.93 (Official Build) (64-Bit)
  • Local OS: Windows 10
  • Remote OS: Linux (Docker image)
  • Remote Architecture: x64
  • code-server --version: 3.10.0 f9b6d04

Steps to Reproduce

  1. Load code-server webpage
  2. Open terminal window
  3. => Unreadable Text
  4. Open settings
  5. Change terminal font size
  6. => Readable Text

Expected

Terminal window text should be displayed correctly

Actual

Every character of the terminal window text is clipped on the right and bottom side

Logs

image
image

Screenshot

code-server_terminal

Notes

The issue does not occur in Google Chrome and Microsoft Edge (Chromium) browsers.

This issue can be reproduced in VS Code: No

@oxy
Copy link

oxy commented May 11, 2021

This appears to be a bug in Brave - since it works on vanilla Chromium/Google Chrome, and also on Firefox/Safari. Can you file it upstream?

@ajhalili2006
Copy link

Also @fuse314, can you add the link to the Chromium bug tracker related to this issue at the issue description?

@ajhalili2006
Copy link

ajhalili2006 commented May 12, 2021

The issue can be also reproduced on Microsoft Edge (EDIT: it was an older version), as shown in the screenshot below.

image


Debugging info

Browser version: Microsoft Edge 89.0.774.77 (Official build) (64-bit)
Local OS: Windows 10 Version 20H2 (OS Build 19042.928)
Remote OS: Linux (Docker container hosted on Divio, formerly Aldryn)
Remote Archeitechure: x86_64
code-coder Version: 3.10.0 f9b6d04

@cstrat
Copy link

cstrat commented May 17, 2021

I am also having this issue, pretty much identical setup. (running on Docker on a server, using Brave as my browser)

Thanks @fuse314, I didn't realise changing the font-size would help fix it (even if its just for that session). Better than squinting... 😆

@fuse314
Copy link
Author

fuse314 commented May 17, 2021

I found this ticket upstream:
brave/brave-browser#14918

If I allow fingerprinting for my domain, the text is rendered correctly.

To fix this:

  1. Click on "Brave Shield" logo
  2. Under "Fingerprinting", select "Allow fingerprinting"
  3. Enjoy

@fuse314 fuse314 closed this as completed May 17, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented May 17, 2021

Woo! Glad you found it filed upstream and posted the fix/workaround. Thanks @fuse314 !

@cstrat
Copy link

cstrat commented May 17, 2021

Amazing, thanks!

@antofthy
Copy link

antofthy commented Jun 2, 2021

I am also having this issue....

capture_2021-06-02_15-49-22

I was able to fix it by copying the font family settings from
Text Editor-> Font -> Font Family
In to the terminal font family settings (which was blank)
Features->Terminal -> Font Family
resulting in..

capture_2021-06-02_16-04-39

Of course according the description (visible in the last image) code-server is supposed to do that automatically! It just didn't happen!

@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 2, 2021

If you've having issues, please open a separate bug report! Thank you!

@coder coder locked as resolved and limited conversation to collaborators Jun 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Needs to be fixed upstream
Projects
None yet
Development

No branches or pull requests

6 participants